[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Small bug in wl-summary.el?



At Sat, 16 Oct 2010 17:50:17 -0700,
Erik Hetzner wrote:
> 
> Hi,
> 
> I noticed that when opening folders WL sometimes spends a bit of time
> “Re-scanning...” Looking at the code, this didn’t seem to be right. I
> noticed that the function wl-summary-view-old-p sometimes returns true
> when perhaps it shouldn’t.
> 
> It seems that the variable wl-summary-buffer-number-list is sometimes
> set (at least in my buffers) to '(nil) (not plain old nil). (Perhaps
> this is because I sometimes interrupt opening a folder with C-g.) When
> the Summary buffer is empty and the value of
> wl-summary-buffer-number-list is '(nil), wl-summary-view-old-p will
> return t, necessitating a rescan when opening a buffer. Here is a
> modified version of wl-summary-view-old-p which checks for this
> situation.
> 
> Am I wrong to make this change? Any thoughts? 

My thoughts: if wl-summary-buffer-number-list is never supposed to be
'(nil), the most principled thing to do would be to discover why it's
adopting that value.

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com